Skip to content

Fix: hbase reduce image size #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 7, 2025
Merged

Fix: hbase reduce image size #1028

merged 12 commits into from
Apr 7, 2025

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Mar 14, 2025 •
edited
Loading

Description

part of #961

REPOSITORY                              TAG                                   IMAGE ID       CREATED         SIZE
oci.stackable.tech/sdp/hbase            2.6.1-stackable25.3.0-reduced-size    6156042ef58b   5 minutes ago   1.76GB
oci.stackable.tech/sdp/hbase            2.6.1-stackable25.3.0                 7f463d69a327   2 days ago      2.62GB
  • Remove chowns from final image (done in copy)
  • Remove chmod from final image (done in each builder)
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder (example for nifi)
 => [nifi-2_2_0 final  7/10] RUN <<EOF (microdnf update...)                                                                                                                                         8.2s
 => ERROR [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...)                                                                                                         0.9s
------
 > [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...):
0.601 Ownership mismatch:  /stackable/nifi (Expected: 1000:0, Found: 0:0)
0.622 Permission mismatch: /stackable/python (Owner: rwx, Group: r-x)
0.624 Permission mismatch: /stackable/bin (Owner: rwx, Group: r-x)
0.628 Permission mismatch: /stackable/nifi-2.2.0 (Owner: rwx, Group: r-x)
0.843 Permission and Ownership checks failed for /stackable!

@maltesander maltesander mentioned this pull request Mar 19, 2025
Closed
@maltesander maltesander marked this pull request as ready for review March 28, 2025 13:48
@maltesander maltesander self-assigned this Mar 28, 2025
@maltesander maltesander moved this to Development: In Progress in Stackable Engineering Mar 28, 2025
@maltesander maltesander moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Mar 28, 2025
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 4, 2025
@siegfriedweber siegfriedweber self-requested a review April 4, 2025 12:03
siegfriedweber
siegfriedweber requested changes Apr 4, 2025
View reviewed changes
@maltesander @siegfriedweber
Update hbase/Dockerfile
241cea7 
Co-authored-by: Siegfried Weber <[email protected]>
siegfriedweber
siegfriedweber previously approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Apr 7, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Apr 7, 2025
Merged via the queue into main with commit 59cb54d Apr 7, 2025
3 checks passed
@maltesander maltesander deleted the fix/hbase-reduce-image-size branch April 7, 2025 11:38
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels

customer-request release/25.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maltesander @siegfriedweber @lfrancke @sbernauer